@jtpio @blink1073, could you please enable the Github Actions workflow here?

Done, thanks @andfoy!

Thanks! @blink1073

@blink1073, sorry for pinging again, but it seems that the permission got revoked?

Ah, probably due to a force push

We can squash at the end

Ah, it looks like it isn't here that we are seeing issues, but in the notebook tests

We only run the most basic test in CI on windows

@blink1073 Do the other tests fail here if we try to run them in Windows?

Do the other tests fail here if we try to run them in Windows?

They already did on the older version of pywintpty, which is why we had skipped them originally.

Let me try to run them again, and see if they are still failing, maybe they can explain the failures in the notebook

This permission setting for first time contributors seems to be very uncomfortable

I don't see a way to change it in the docs

@blink1073, I managed to fix the tests on Windows, Some tests related to single terminals and max terminals hang, so I don't know if that plays part on the notebook errors

so I don't know if that plays part on the notebook errors

I'm not sure, are you available to test notebook against your pywinpty_1.0.1 branch?

Thanks for fixing those tests!

I'm not sure, are you available to test notebook against your pywinpty_1.0.1 branch?

The RDP session is still open, so I can try to test it

I got to reproduce the errors locally, it seems that the errors are related to the terminate method, which I don't know what it does underneath and how it interacts with terminado/pywinpty

I did some changes to ptyprocess in https://github.com/spyder-ide/pywinpty/pull/137/files#diff-4a67b83c782a0c2991144686e69d148dc649326c957c603349b7a3d43f8bab18, however, I don't know if those changes broke something? I don't know if removing the close method on the PTY object is somewhat involved here

I don't know if those changes broke something

It appears so, because the terminals are successfully terminated if we pin to the previous version.

@blink1073, could you give us a help there? I touched some of the functionality of ptyprocess, but since you wrote the module, maybe you could verify that is working as expected?

hi, is there a possiblity you can produce a wheel for pypy3.7-v7.3.5-win64 ? Is it even possible ? it seems a big challenge to me with rust in the middle not happy with PyPy